Xu He Jie has posted comments on this change. Change subject: Add simple text-based console in vdsClient ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 1614: protocol = "tls" if self.useSSL else "tcp" Line 1615: conn = "qemu+" + protocol + "://" + self.server + "/system" Line 1616: p = subprocess.Popen(["virsh", "-c", conn, "console", args[0]]) Line 1617: p.wait() Line 1618: return 0, '' Vdsm didn't set listen_tls=1 directly. But listen_tls=1 is default value as the comment in libvirtd.conf. And in line 305, vdsm always add --listen in /etc/sysconfig/libvirtd. So it equals listen_tcp=1 and listen_tls=1. Only when ssl=false, vdsm set the listen_tcp and listen_tls in libvirtd.conf. Line 1619: Line 1620: Line 1621: if __name__ == '__main__': Line 1622: if _glusterEnabled: -- To view, visit http://gerrit.ovirt.org/8041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
