Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 10: (36 comments) https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 1: ConnectionRefs I do not see any ConnectionRefs* commands in the engine. Do we still use them? Line 738: swap_usage Is this used? I do not see it in the engine nor vdsm Line 747: mem_cached same as above Line 752: mem_buffers same as above Line 960: needs updating What is the default value? Line 984: needs updating What is the default value? Line 989: needs updatin What is the default value? Line 994: needs updating What is the default value? Line 999: needs updating What is the default value? Line 1046: needs updating What is the default value? Line 1051: needs updating What is the default value? Line 1055: needs updating What is the default value? Line 1060: needs updating What is the default value? Line 1065: needs updating What is the default value? Line 1069: needs updating What is the default value? Line 1094: needs updating What is the default value? Line 1102: needs updating What is the default value? Line 1251: needs updating What is the default value? Line 1257: (made optional in version : 4.17.0) Do we support this kind of operations? How older engines react when the value is not there? Line 1259: displayType What is the default value? Line 1305: (made : optional in version 4.17.0) The same as for displayPort. Do we break backward compatibility? Line 1333: needs updating What is the default value? Line 1376: (Renamed and changed to boolean in version 4.17.0.) How do we handle it in older engines? Line 1459: (Renamed and changed to boolean in version 4.17.0.) How do we handle it in older engines? Line 1471: needs updating What is the default value? Line 1613: (Renamed and changed to boolean in version : 4.17.0.) How do we handle it in older engines? Line 1681: needs updating What is the default value? Line 1686: needs updating What is the default value? Line 1702: needs updating What is the default value? Line 1875: (Renamed and changed to boolean in version 4.17.0.) How this change work with older engine? Line 2220: needs updating what is the default value? Line 2224: needs updating what is the default value? Line 2228: needs updating what is the default value? Line 2232: needs updating what is the default value? Line 2236: needs updating what is the default value? Line 2240: needs updating what is the default value? -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
