Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 38: - defaultvalue: needs updating Line 39: description: The amount of memory requested (in KiB) Line 40: name: balloon_target Line 41: type: string Line 42: type: type > object In old schema it was defined as type. We have aliases, union, maps, enums and types. hmm sounds like good idea. Let's hear whether others like it. Line 43: Line 44: BandwidthCurve: &BandwidthCurve Line 45: added: '3.6' Line 46: description: Bandwidth traffic Line 147: Line 148: - description: The physical device name Line 149: name: physdev Line 150: type: string Line 151: type: type > this is an object then call it like this, and that shouldn't be params but properties looks good will change. Line 152: Line 153: IscsiSessionInfo: &IscsiSessionInfo Line 154: added: '3.1' Line 155: description: Information about a single, active iSCSI session. -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
