Nir Soffer has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 11: (5 comments) https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 130: params: Line 131: - description: The SCSI Logical Unit Number associated with Line 132: this path Line 133: name: lun Line 134: type: uint The order should be name, type, description or name, description, type, but certainly not description, name, type. Line 135: Line 136: - description: The path size (in bytes) (new in version 4.17) Line 137: name: capacity Line 138: type: uint Line 132: this path Line 133: name: lun Line 134: type: uint Line 135: Line 136: - description: The path size (in bytes) (new in version 4.17) (new in version xxx) should be a property of the parameter, like "added" for the entire api. Line 137: name: capacity Line 138: type: uint Line 139: Line 140: - description: The type of path (BlockDeviceType) Line 147: Line 148: - description: The physical device name Line 149: name: physdev Line 150: type: string Line 151: type: type this is little weak. Line 152: Line 153: IscsiSessionInfo: &IscsiSessionInfo Line 154: added: '3.1' Line 155: description: Information about a single, active iSCSI session. Line 201: params: Line 202: - description: The LVM physical volume size (in bytes) Line 203: name: pvsize Line 204: type: uint Line 205: added: '3.6' This looks good for (new in version xxx). Line 206: Line 207: - description: The device status (free/used/unknown) Line 208: name: status Line 209: type: *BlockDeviceStatus Line 276: unknown: The block job type is not known Line 277: or supported Line 278: Line 279: JobType: &JobType Line 280: added: '3.4' added should be last Line 281: description: An enumeration of job types Line 282: name: JobType Line 283: type: enum Line 284: values: -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
