Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: provide more info when method not found ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53714/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 74: result = None Line 75: try: Line 76: fn = getattr(self, methodName) Line 77: except AttributeError: Line 78: raise yajsonrpc.JsonRpcMethodNotFoundError(methodName) > Why do you fix dead code? better remove it before this patch so you don't h OK will add a patch to remove dead code. Line 79: Line 80: try: Line 81: result = fn(argobj) Line 82: except VdsmError as e: -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches