Nir Soffer has posted comments on this change. Change subject: jsonrpc: provide more info when method not found ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/53714/2/tests/integration/jsonRpcTests.py File tests/integration/jsonRpcTests.py: Line 147: CALL_ID) Line 148: Line 149: self.assertEquals( Line 150: cm.exception.code, Line 151: JsonRpcMethodNotFoundError(missing_method).code) You are not testing here that missing_method was included in the error. Do we get the error attributes in the client, or only the error code? If you want to check the code, you should do: JsonRpcMethodNotFoundError.code (Assuming that the code is a class attribute). Line 152: Line 153: @permutations(PERMUTATIONS) Line 154: def testMethodBadParameters(self, ssl, type): Line 155: # Without a schema the server returns an internal error -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches