Dan Kenigsberg has posted comments on this change. Change subject: vdsmd: remove bashisms found with checkbashism script on ubuntu ......................................................................
Patch Set 1: would it be profane to ask what's so bad about bashism? Obviously, having bashism with /bin/sh on top is a bug. But is it really important to fork an exec /usr/bin/[ whenever you want to evaluate something? I share the puritan sentiment, just wonder if there's something practical behind it, as debian has /bin/bash... -- To view, visit http://gerrit.ovirt.org/8336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece592e9cc3dfa361c99812461d783bff7f780a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
