Ryan Harper has posted comments on this change. Change subject: vdsmd: remove bashisms found with checkbashism script on ubuntu ......................................................................
Patch Set 1: If you prefer to switch to /bin/bash I don't mind at all. I just know that on ubuntu, for example, /bin/sh points to /bin/dash which falls apart over bashisms. I know we don't yet fully support ubuntu or debian as hosts, but we might as well not make it harder in the future. Additionally, I appreciate the concern about forking() via [, but recall that these are not in the fast path (service start, stop). I'm more interested in picking a shell and sticking to that than I'm worried about micro-optimizing the shell code that's run so infrequently. -- To view, visit http://gerrit.ovirt.org/8336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece592e9cc3dfa361c99812461d783bff7f780a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
