Freddy Rolland has posted comments on this change. Change subject: net: IP address hostport split tool ......................................................................
Patch Set 4: I tend to agree that this tool should be in a common space. We should try to separate the packages. Adding more dependencies will make it harder in the future to separate the processes. We could have for utilities: lib/vdsm/common lib/vdsm/common/network lib/vdsm/common/storage lib/vdsm/common/virt In that way responsibility will be clear. Also moving all the modules from lib/vdsm to lib/vdsm/common will make everything cleaner. -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
