Francesco Romani has posted comments on this change. Change subject: net: IP address hostport split tool ......................................................................
Patch Set 4: The discussion about future split is very important and very interesting, but I feel is out of place here :) I agree this should be in the common part. My rule of thumb - until I find a better one is 1. facilities provided by a vertical/service (e.g. run a vm, prepare an image...) should be an API entry point, so the boundary is obvious 2. utilities in importable modules used all across the applications should be moved in the shared library (in broad CS term), the vdsm-common package mentioned by Nir/Fred e.g. compare from vdsm.common import some_utility I feel we are in the case #2 now. In virt we have a "staging area" (vdsm/virt/utils.py) for importable utilities that we *believe* could be used elsewhere, but we are not sure yet. That's all for me, but I urge all the developers involved to move this important discussion in a more suitable place, and to agree about general guidelines ASAP (maybe wiki page)? No need to be overly detailed, just few broad directions are a fine start. -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
