Francesco Romani has posted comments on this change. Change subject: osinfo: avoid excepting * ......................................................................
Patch Set 1: (1 comment) it is fine to address my comments in a later patch to keep this trivial. https://gerrit.ovirt.org/#/c/54545/1/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 193: for pkg, names in KEY_PACKAGES.iteritems(): Line 194: try: Line 195: mi = itertools.chain(*[ts.dbMatch('name', name) Line 196: for name in names]).next() Line 197: except StopIteration: > how? that is the standard approach for iterations I know, but feels too lower level. I'd rather use something with zip. But this is utterly unrelated to this patch. Line 198: logging.debug("rpm package %s not found", Line 199: KEY_PACKAGES[pkg]) Line 200: else: Line 201: pkgs[pkg] = { -- To view, visit https://gerrit.ovirt.org/54545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
