Dan Kenigsberg has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName ......................................................................
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/54510/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-03-11 13:31:22 +0100 Line 6: Line 7: caps: use storage's getDefaultInitiatorName Line 8: Line 9: Caps reimplemented the functionality to acquire host's scsi initiator actually, https://bugzilla.redhat.com/show_bug.cgi?id=571348 came before storage/iscsi ever existed, but removing code duplications is noble. Nir has expressed worries about importing functions from one system into another. I persollay believe that this patch is perfectly reasonable. However, getDefaultInitiatorName is less precise than the removed function, as /etc/iscsi/initiatorname.iscsi may include an InitiatorAlias according to iscsiadm man page, so I think that its implementation should be made a bit more robust (in another patch, possibly). Line 10: name. This patch throws away the reimplementation and uses Line 11: getDefaultInitiatorName from storage/iscsi. Line 12: Line 13: Change-Id: If49286165b7855b96dd88221de06579485d576f4 -- To view, visit https://gerrit.ovirt.org/54510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If49286165b7855b96dd88221de06579485d576f4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
