Nir Soffer has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54510/4/vdsm/caps.py File vdsm/caps.py: Line 43: from vdsm import numa Line 44: from vdsm import host Line 45: from vdsm import utils Line 46: import storage.hba Line 47: import storage.iscsi You cannot do that, storage package is private for the storage component of vdsm, there can be no dependencies from other packages. If you need something from the iscsi module, it should move to lib.vadm.common package. Line 48: from virt import vmdevices Line 49: Line 50: # For debian systems we can use python-apt if available Line 51: try: -- To view, visit https://gerrit.ovirt.org/54510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If49286165b7855b96dd88221de06579485d576f4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
