Edward Haas has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/52864/21/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 6697: - *vmUpdateInterfaceDeviceParams Line 6698: - *vmUpdateGraphicsDeviceParams Line 6699: Line 6700: Line 6701: Host.setupNetworks: setupNetworks API is default-unfriendly. We use the input as is and save it for persistence config. The main risk is with saving these defaults. We would have more control if we handle the defaults of networking in a separated patches (incrementally) without affecting other parts. Could you please set all defaults to no-default? Line 6702: added: '3.1' Line 6703: description: Reconfigure host networking by adding, removing, and editing Line 6704: multiple bridgeand bond devices in a single call. Line 6705: params: -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
