Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 17: (20 comments) https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 5659: needs updating > could be missing if no GuestAgent is not available - which is not recommend Done Line 5693: needs updating > could be missing entirely if VM is headless (legal). Done Line 5699: needs updating > same as timezone Done Line 5776: needs updating > same as displayPort Done Line 5790: needs updating > same as displayPort Done Line 6042: needs updating > default: false Done Line 6049: needs updating > could be missing, in this case the VM will be headless. It is legal and sup Done Line 6055: needs updating > default is 'not present', that for us is equivalent to 'false' Done Line 6064: needs updatin > default is 1 Done Line 6073: needs updating > Vdsm doesn't require this, so it could be missing. But starting from 3.6 I Done Line 6083: needs updating > default is false Done Line 6089: needs updating > default is no attribute, so maybe 'null' Done Line 6094: needs updating > newer (>= 3.5) Engines always send this. Done Line 6121: needs updating > default is no explicit tuning. So maybe 'null'? Done Line 6126: eeds updating > default is 1 Done Line 8580: monitorCommand > not actually implemented (and no plans to do so) should we remove it? Line 8600: description: '' : type: *VmDefinition > according to the code (vm.py) this just returns response.success() or respo hmm, so it should be no return block here. Will fix Line 8611: sendKeys > this is actually unsupported and kept for backward compatibility (?!) - che should we remove it? Line 8688: berequired > needs spacing: be required Thanks Line 8697: berequired > needs spacing: be required Thanks -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
