Piotr Kliczewski has posted comments on this change. Change subject: WIP: POC: virt: common handling of exception ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54664/2/lib/vdsm/virt/utils.py File lib/vdsm/virt/utils.py: Line 35: def api_method(func): Line 36: @wraps(func) Line 37: def wrapper(*args, **kwargs): Line 38: try: Line 39: ret = func(*args, **kwargs) > We cannot do this, there is no code in ret - this is the payload returned b hmm, ok Line 40: except exception.VdsmException as e: Line 41: return e.response() Line 42: else: Line 43: if ret is not None: -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
