Francesco Romani has posted comments on this change. Change subject: virt: common handling of exceptions ......................................................................
Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54664/7/lib/vdsm/virt/api.py File lib/vdsm/virt/api.py: Line 45: Line 46: _log.debug("FINISH %s response=%s", func.__name__, ret) Line 47: Line 48: if isinstance(ret, dict): Line 49: return response.success(**ret) > I just noticed this, we should not do this. OK, I used to do like this and I changed in v7. Will restore the old behaviour like you requested. It is easy to port existing verbs to this behaviour. Line 50: return response.success() Line 51: -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
