Zhou Zheng Sheng has uploaded a new change for review. Change subject: hsm: use misc.parseBool instead of ad-hoc bool convertion ......................................................................
hsm: use misc.parseBool instead of ad-hoc bool convertion Change-Id: I2ce0ec34d10380c8e1e8bd94e17ef436deb28579 Signed-off-by: Zhou Zheng Sheng <[email protected]> --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/8482/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 50d6ce1..e1f61c7 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1705,9 +1705,7 @@ lvm.createVG(vgname, devices, blockSD.STORAGE_UNREADY_DOMAIN_TAG, metadataSize=blockSD.VG_METADATASIZE, - force=(force == True) or \ - (type(force) == type("") and \ - (force.capitalize() == "True"))) + force=misc.parseBool(force)) return dict(uuid=lvm.getVG(vgname).uuid) -- To view, visit http://gerrit.ovirt.org/8482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ce0ec34d10380c8e1e8bd94e17ef436deb28579 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
