Zhou Zheng Sheng has posted comments on this change.
Change subject: hsm: use utils.tobool instead of ad-hoc bool convertion
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1705: raise se.VolumeGroupSizeError("VG size must be more than
%s MiB" % str(MINIMALVGSIZE / constants.MEGAB))
Line 1706:
Line 1707: lvm.createVG(vgname, devices,
blockSD.STORAGE_UNREADY_DOMAIN_TAG,
Line 1708: metadataSize=blockSD.VG_METADATASIZE,
Line 1709: force=utils.tobool(force))
Excuse me, what do you mean by "Adding here a new dependency can be avoided"?
Do you mean that we should turn all parseBool calls into utils.tobool, or just
continue to use the original ad-hoc code to avoid dependency to utils.py?
Line 1710:
Line 1711: return dict(uuid=lvm.getVG(vgname).uuid)
Line 1712:
Line 1713:
--
To view, visit http://gerrit.ovirt.org/8482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce0ec34d10380c8e1e8bd94e17ef436deb28579
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
