Doron Fediuck has posted comments on this change. Change subject: start ksm and ksmtuned when vdsm starts ......................................................................
Patch Set 2: (1 inline comment) Dan, this is better since if configuration does not want ksm, we will not start it. So for now we maintain existing behavior and allow muting ksm when needed. .................................................... File vdsm/ksm.py Line 92: return npages Line 93: except: Line 94: return 0 Line 95: Line 96: def ksm_start(): Shu Ming, calling 'start' for a running service does nothing if the service is already running. So this is the desired behavior; if the service is running (auto-started in the init phase), nothing happens. Else, it should start now. Line 97: utils.execCmd([constants.EXT_SERVICE, 'ksmtuned', 'start'], sudo=True) Line 98: utils.execCmd([constants.EXT_SERVICE, 'ksm', 'start'], sudo=True) Line 99: Line 100: def tune(params): -- To view, visit http://gerrit.ovirt.org/8357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia50087aae112069b2a427fca12168aff975b443e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
