Dan Kenigsberg has posted comments on this change. Change subject: start ksm and ksmtuned when vdsm starts ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Shu Ming: currently ksm/ksmtuned are not started nor explicitly required by vdsmd. Doron would like to keep it this way, in order to be able to switch from them to MOM according to a configurable. I tend to accept his argument. .................................................... File vdsm/ksm.py Line 1: # Line 2: # Copyright 2011 Red Hat, Inc. do you intentionally ignore my stupid first comment? don't you love lawyers like everybody? Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/8357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia50087aae112069b2a427fca12168aff975b443e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
