Nir Soffer has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54856/5/.travis.yml
File .travis.yml:

Line 11:   - docker --version
Line 12:   - docker pull edwardhaas/ovirt-vdsm-dev
Line 13: 
Line 14: script:
Line 15:   - docker run --rm=true -it -v `pwd`:/vdsm:rw 
edwardhaas/ovirt-vdsm-dev /bin/bash -c "cd /vdsm && ./autogen.sh --system && 
make; make check-unit"
> Nice, but are you sure we need --rm and running interactive session (-it)?
We can add other image later, just make sure that it will be easy by renaming 
the Dockerfile to something like Dockerfile.centos-7


-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: David Caro <dc...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to