Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 11: - docker --version Line 12: - docker pull edwardhaas/ovirt-vdsm-dev Line 13: Line 14: script: Line 15: - docker run --rm=true -it -v `pwd`:/vdsm:rw edwardhaas/ovirt-vdsm-dev /bin/bash -c "cd /vdsm && ./autogen.sh --system && make; make check-unit" > Right, we don't need any cloning or checkouts for travis, and for local use State is not left, I mentioned that all usages (I saw) of running an image with a job specified from 'outside' is with the interactive mode. We need `pwd`:/vdsm:rw to mount the current path on the CI host to /vdsm folder inside the docker image. The cloned git repo is on the current path. check-unit is good enough for running just unit tests. It currently runs all tests that are tagged with: type=unit I found it more reasonable to classify what is a unit test and add to the list (white list) than the other way around. But that is not the only way to go on other verticals, you can propose having an alternative logic instead when you will classify tests: type=unit OR (type!=functional AND type!=integration) It's actually not related to this patch, so even if this needs to change, it should have its own patch. https://gerrit.ovirt.org/#/c/54856/5/contrib/Dockerfile File contrib/Dockerfile: Line 9: Line 10: CMD mkdir workspace && \ Line 11: cd workspace && \ Line 12: git clone http://gerrit.ovirt.org/p/vdsm.git && cd vdsm && \ Line 13: ./autogen.sh --system; make; make check-unit > I don't think we need it, whats the point in checking out master and runnin It's a reference point... I run things on my branch and want to compare to a run on master. The master branch is always there, running tests on it by default is useful to me. -- To view, visit https://gerrit.ovirt.org/54856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Caro <dc...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
