Ondřej Svoboda has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54130/3/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: Line 157 Line 158 Line 159 Line 160 Line 161 > even though this function has become so much simpler, I think that it makes I moved the check "dhclient.supports_duid_file()" to the configurators because I think the API shouldn't care how DUID is finally handled (ideally, if -df is not supported, another method (-lf) should be tried transparently). And the long comment inside the target function to explain its purpose. This leaves us only with the now-inlined assignment (which got the useful parts of the docstring as a comment) because the check that there is a port has always been done by the caller. I don't think we need a single-statement function. -- To view, visit https://gerrit.ovirt.org/54130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
