Ondřej Svoboda has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54130/5/lib/vdsm/network/configurators/dhclient.py File lib/vdsm/network/configurators/dhclient.py: PS5, Line 134: subprocess > Bypassing execCmd here seems like a hack, I'm not sure if we know what we a All I found about dhcpctl was that it was "a set of functions to control the dhcp server". Anyway, I don't think we want to tie ourselves to the one DHCP client any more than we already do. I reacted to Popen/CPopen elsewhere. -- To view, visit https://gerrit.ovirt.org/54130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
