Martin Polednik has posted comments on this change. Change subject: hostdev: add support for hotplug ......................................................................
Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/42661/10/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2117: index > what do you need this for? leftovers! :( will remove Line 2140: self.saveState() : self._getUnderlyingHostDeviceInfo() > question: why after each iteration and not just once after the loop ended? Difficult question. As the call can be quite complex to execute compared to others, this was idea of 'some' security. Would you prefer only a single call at the end? Line 2143: list > why explicit call to list()? used set before, will fix! -- To view, visit https://gerrit.ovirt.org/42661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
