Francesco Romani has posted comments on this change. Change subject: hostdev: add support for hotplug ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/42661/10/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2140: self.saveState() : self._getUnderlyingHostDeviceInfo() > Difficult question. As the call can be quite complex to execute compared to I don't have strong feelings yet. I'm trying to think what is 1. safer 2. faster (in this order) if we move likes 2134-2141 out of the loop and if we do those operations in bulk. -- To view, visit https://gerrit.ovirt.org/42661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
