Dan Kenigsberg has posted comments on this change. Change subject: vdsm_reg: generate deployUtil.py and config.py ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Thanks for the fix, but I'd be happier to understand more. .................................................... Commit Message Line 5: CommitDate: 2012-10-11 17:24:03 -0400 Line 6: Line 7: vdsm_reg: generate deployUtil.py and config.py Line 8: Line 9: Adding nodist_vdsmreg_PYTHON to all-local target. Otherwise, deployUtil.py and configy.in won't be generated. could you fix the nd configy.in typo, keep the line shorter, and explain when was this issue introduced? and why wasn't it noticed by `make rpm`? I would like know so as not to repeat former mistakes. Line 10: Thanks to Ravi Nori for the IRC report! Line 11: Line 12: Change-Id: I7d4902b3d1c95da4bcb96aea26d4b75b41a10a61 -- To view, visit http://gerrit.ovirt.org/8511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d4902b3d1c95da4bcb96aea26d4b75b41a10a61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
