Dan Kenigsberg has posted comments on this change. Change subject: vdsm_reg: generate deployUtil.py and config.py ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2012-10-23 11:32:54 -0400 Line 6: Line 7: vdsm_reg: generate deployUtil.py and config.py Line 8: Line 9: Adding nodist_vdsmreg_PYTHON to all-local target. Otherwise, deployUtil.py and config.py won't be generated. it is not the end of the world, but please break commit message lines in the future. Line 10: Thanks to Ravi Nori for the report! Line 11: Line 12: Introduced by commits: Line 13: 9459af3fa7f823d04d6e3ac5c5439ec6b2b6e961 (deployUtil) -- To view, visit http://gerrit.ovirt.org/8511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d4902b3d1c95da4bcb96aea26d4b75b41a10a61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
