Ayal Baron has posted comments on this change.
Change subject: upgrade: handle the templates lease files
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/fileVolume.py
Line 225:
Line 226: def _shareLease(self, dstImgPath):
Line 227: """
Line 228: Internal utility method used during the share process and by
the
Line 229: domain V3 upgrade.
'used by' can change dynamically and this comment will become obsolete.
Comment should explain what the method does, not who uses it.
Line 230: """
Line 231: self.log.debug("Share volume lease of %s to %s", self.volUUID,
Line 232: dstImgPath)
Line 233: dstLeasePath = self._getLeaseVolumePath(
--
To view, visit http://gerrit.ovirt.org/8271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I886f887438220e61f8764fc3d32d7b99609d8543
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
