Dan Kenigsberg has posted comments on this change.
Change subject: upgrade: handle the templates lease files
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 148: v3UpgradeVolumePermissions(vol)
Line 149:
Line 150: log.debug("Creating the volume lease for %s", volUUID)
Line 151: metaId = vol.getMetadataId()
Line 152: type(vol).newVolumeLease(metaId, domain.sdUUID, volUUID)
why are you taking type(vol)? wouldn't vol.newVolumeLease be enough?
Line 153:
Line 154: # If this volume is used as a template let's update the
other
Line 155: # volume's permissions and share the volume lease (at the
moment
Line 156: # of this writing this is strictly needed only on file
domains).
--
To view, visit http://gerrit.ovirt.org/8271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I886f887438220e61f8764fc3d32d7b99609d8543
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
