Greg Padgett has uploaded a new change for review. Change subject: storage: can't create gpfs domain ......................................................................
storage: can't create gpfs domain Validation for ':' in the path during creation of posix storage domains causes failure when creating gpfs domains; instead, check this only for nfs domains. Change-Id: Idff4c01467838991ad4a5ee5c80e16ced77939a1 Signed-off-by: Greg Padgett <[email protected]> --- M vdsm/storage/nfsSD.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/8525/1 diff --git a/vdsm/storage/nfsSD.py b/vdsm/storage/nfsSD.py index d84fee6..f0f362b 100644 --- a/vdsm/storage/nfsSD.py +++ b/vdsm/storage/nfsSD.py @@ -32,9 +32,10 @@ class NfsStorageDomain(fileSD.FileStorageDomain): @classmethod - def _preCreateValidation(cls, sdUUID, domPath, typeSpecificArg, version): + def _preCreateValidation(cls, sdUUID, domPath, typeSpecificArg, + storageType, version): # Some trivial resource validation - if ":" not in typeSpecificArg: + if storageType == sd.NFS_DOMAIN and ":" not in typeSpecificArg: raise se.StorageDomainIllegalRemotePath(typeSpecificArg) sd.validateDomainVersion(version) @@ -74,7 +75,8 @@ mntPoint = os.path.join(cls.storage_repository, sd.DOMAIN_MNT_POINT, mntPath) - cls._preCreateValidation(sdUUID, mntPoint, remotePath, version) + cls._preCreateValidation(sdUUID, mntPoint, remotePath, storageType, + version) domainDir = os.path.join(mntPoint, sdUUID) cls._prepareMetadata(domainDir, sdUUID, domainName, domClass, -- To view, visit http://gerrit.ovirt.org/8525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idff4c01467838991ad4a5ee5c80e16ced77939a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
