Greg Padgett has posted comments on this change. Change subject: storage: can't create gpfs domain ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/nfsSD.py Line 31: Line 32: class NfsStorageDomain(fileSD.FileStorageDomain): Line 33: Line 34: @classmethod Line 35: def _preCreateValidation(cls, sdUUID, domPath, typeSpecificArg, Indeed, it would. Next I'd like to refactor to make a separate PosixStorageDomain class (maybe a MountableFileStorageDomain class as a common parent to it and NfsStorageDomain). Line 36: storageType, version): Line 37: # Some trivial resource validation Line 38: # TODO Checking storageType==nfs in the nfs class is not clean Line 39: if storageType == sd.NFS_DOMAIN and ":" not in typeSpecificArg: -- To view, visit http://gerrit.ovirt.org/8525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idff4c01467838991ad4a5ee5c80e16ced77939a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
