Francesco Romani has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 1: Code-Review-1 (3 comments) I like the idea, but we need to tune some details. -1 for visibility while we discuss. https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vm.py File vdsm/virt/vm.py: PS1, Line 1866: for dev_type, dev_objects in self._devices.items(): : for dev_object in dev_objects: : dev_object.setup() (minor) I'd have setupDevices for symmetry. Perhaps: make both plain functions and move into vmdevices.common ? It *is* debatable to have this as plain functions, but same applies for methods: we don't use 'self' much after all. https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: PS1, Line 79: right before VM's XML is generated. not sure this is the best place PS1, Line 80: in the recovery flow. the information is correct, but we actually mean "when the device object is created", don't we? -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
