Martin Polednik has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vm.py File vdsm/virt/vm.py: PS1, Line 1866: for dev_type, dev_objects in self._devices.items(): : for dev_object in dev_objects: : dev_object.setup() > (minor) I'd have setupDevices for symmetry. Sure for the setupDevices. Although I hate common modules, if you feel it is way better then I'm fine with it. I'm afraid of hiding the fact that it'll operate on _devices objects. https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: PS1, Line 79: right before VM's XML is generated. > not sure this is the best place It is *the* place for this in my opinion. I think that the docstring is awkwardly worded (also applies for comment below). -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
