Liron Aravot has uploaded a new change for review.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
......................................................................
fileUtils: tarCopy - avoid extracting the file modified time
We using fileUtils.tarCopy() when there are unsynced clocks between
the source/destination tar might warn us that the source timestamp is
in the future (when we copy from/to file).
This error is logged to stderr, if the copy operation fails for some other
reason the stderr might be flooeded with timestamp in the future errors which
is confusing when analyzing the cause to the failure.
As we don't case about the timestamp this patch adds the -m flag which
doesn't extract the file modified date and by that eliminates the error.
Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M vdsm/storage/fileUtils.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/55163/1
diff --git a/vdsm/storage/fileUtils.py b/vdsm/storage/fileUtils.py
index eb20c97..0d6946b 100644
--- a/vdsm/storage/fileUtils.py
+++ b/vdsm/storage/fileUtils.py
@@ -61,7 +61,7 @@
tsrc = subprocess.Popen([constants.EXT_TAR, "cf", "-"] +
excludeArgs + ["-C", src, "."],
stdout=subprocess.PIPE)
- tdst = subprocess.Popen([constants.EXT_TAR, "xf", "-", "-C", dst],
+ tdst = subprocess.Popen([constants.EXT_TAR, "xf", "-", "-C", dst, "-m"],
stdin=tsrc.stdout, stderr=subprocess.PIPE,
stdout=subprocess.PIPE)
tsrc.stdout.close()
--
To view, visit https://gerrit.ovirt.org/55163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
