Nir Soffer has posted comments on this change. Change subject: fileUtils: tarCopy - avoid extracting the file modified time ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Looks good, see command about using long options. https://gerrit.ovirt.org/#/c/55163/1/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 60: Line 61: tsrc = subprocess.Popen([constants.EXT_TAR, "cf", "-"] + Line 62: excludeArgs + ["-C", src, "."], Line 63: stdout=subprocess.PIPE) Line 64: tdst = subprocess.Popen([constants.EXT_TAR, "xf", "-", "-C", dst, "-m"], Can you use the long option (--touch) instead? It is easier to debug code using long options. Short options are nice when using the command interactively. Line 65: stdin=tsrc.stdout, stderr=subprocess.PIPE, Line 66: stdout=subprocess.PIPE) Line 67: tsrc.stdout.close() Line 68: out, err = tdst.communicate() -- To view, visit https://gerrit.ovirt.org/55163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches