Edward Haas has posted comments on this change. Change subject: utils: suppress ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/55065/4/vdsm_hooks/ovs/ovs_before_network_setup.py File vdsm_hooks/ovs/ovs_before_network_setup.py: Line 35: from vdsm import hooks Line 36: from vdsm.ipwrapper import linkSet Line 37: from vdsm.netconfpersistence import RunningConfig Line 38: from vdsm.network.configurators import libvirt Line 39: try: > We have compat module which was created to hide details like this. Cool. Line 40: from contextlib import suppress Line 41: except ImportError: Line 42: from vdsm.utils import suppress Line 43: -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
