Edward Haas has posted comments on this change. Change subject: utils: suppress ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55065/6/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 42: try: Line 43: from contextlib import suppress Line 44: suppress # make pyflakes happy Line 45: except ImportError: Line 46: from vdsm.utils import suppress Unfortunately, you have an import loop here. vdsm.utils import pickle from here... Do not use 'utils' junkyard, create a vdsm.common.contextlib extensions. -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches