Saggi Mizrahi has uploaded a new change for review. Change subject: storage: Default to NFSv3 if version not specified ......................................................................
storage: Default to NFSv3 if version not specified This is a policy change rather then a logic change so it should be set in the policy. In any case, it's wrong for VDSM to this and it is actually the managing entities job to set the defaults. I personally don't understand who decided it should be fixed in VDSM but it should only be fixed for the legacy API as it only affects old and current ovirt-engine versions. In actuality the problem will *never* be fixed by a new version of VDSM as it relates to the ovirt-engine's ability to help the user configure the NFS server as well as for VDSM to configure the host. In any case this is not and infrastructure issue so it shouldn't modify the NFS abstraction object. Change-Id: Ia1b46570d0231beae0d1a66d6b1fbdef6ca925d3 Signed-off-by: Saggi Mizrahi <[email protected]> --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/8574/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 50d6ce1..6329389 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -149,7 +149,7 @@ conDict.get('connection', None), conDict.get('retrans', None), conDict.get('timeout', None), - conDict.get('protocol_version', None)) + conDict.get('protocol_version', 3)) elif typeName == 'posixfs': params = storageServer.PosixFsConnectionParameters( conDict.get('connection', None), -- To view, visit http://gerrit.ovirt.org/8574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1b46570d0231beae0d1a66d6b1fbdef6ca925d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
