Ayal Baron has posted comments on this change.
Change subject: storage: Default to NFSv3 if version not specified
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 13: entities job to set the defaults.
Line 14:
Line 15: I personally don't understand who decided it should be fixed in VDSM
but
Line 16: it should only be fixed for the legacy API as it only affects old and
Line 17: current ovirt-engine versions.
Afaiu you fixed it for all APIs, not just connectStorageServer.
The reason V3 should be the default as it works out of the box as opposed to V4
which doesn't.
Line 18:
Line 19: In actuality the problem will *never* be fixed by a new version of VDSM
Line 20: as it relates to the ovirt-engine's ability to help the user configure
Line 21: the NFS server as well as for VDSM to configure the host.
....................................................
File vdsm/storage/hsm.py
Line 148: params = storageServer.NfsConnectionParameters(
Line 149: conDict.get('connection', None),
Line 150: conDict.get('retrans', None),
Line 151: conDict.get('timeout', None),
Line 152: conDict.get('protocol_version', 3))
how would one specify 'auto'?
Line 153: elif typeName == 'posixfs':
Line 154: params = storageServer.PosixFsConnectionParameters(
Line 155: conDict.get('connection', None),
Line 156: conDict.get('vfs_type', None),
--
To view, visit http://gerrit.ovirt.org/8574
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b46570d0231beae0d1a66d6b1fbdef6ca925d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
