Saggi Mizrahi has posted comments on this change. Change subject: storage: failure to reconnect to authenticated iSCSI LUNs ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Also, the svdsm method should only read the iscsi credentials and be called from the original method. In the future, we might detect if credentials are involved to remove contention from svdsm. .................................................... File vdsm/storage/iscsi.py Line 85: targetname = os.path.join(iscsi_session, "targetname") Line 86: iface = os.path.join(iscsi_session, "ifacename") Line 87: tpgt = os.path.join(iscsi_session, "tpgt") Line 88: Line 89: user = os.path.join(iscsi_session, "username") +1 Line 90: passwd = os.path.join(iscsi_session, "password") Line 91: Line 92: paddr = os.path.join(iscsi_connection, "persistent_address") Line 93: pport = os.path.join(iscsi_connection, "persistent_port") .................................................... File vdsm/storage/multipath.py Line 315: # Note that credentials must be sent back in order for Line 316: # the engine to tell vdsm how to reconnect later Line 317: if sess.credentials: Line 318: cred = sess.credentials Line 319: sessionInfo['user'] = cred.username This is actually outward facing so you shouldn't change that. Line 320: sessionInfo['password'] = cred.password Line 321: Line 322: knownSessions[sessionID] = sessionInfo Line 323: devInfo["connections"].append(knownSessions[sessionID]) -- To view, visit http://gerrit.ovirt.org/8523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id717ee5b45adede4f9094f842ead06b0ba91f8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
