Ayal Baron has posted comments on this change. Change subject: storage: failure to reconnect to authenticated iSCSI LUNs ......................................................................
Patch Set 1: > Also, the svdsm method should only read the iscsi credentials and be called > from the original method. In the future, we might detect if credentials are > involved to remove contention from svdsm. Saggi, this would make the code longer and more cumbersome with very little gain if any. In addition, these comments can be addressed in a subsequent patch. btw, it would have been much easier to review your comment inline. -- To view, visit http://gerrit.ovirt.org/8523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id717ee5b45adede4f9094f842ead06b0ba91f8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
