Martin Polednik has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py File vdsm/virt/vm.py: PS4, Line 1689: for dev_objects in self._devices.values(): This is safe in both 2 and 3 as it iterates over device types (those are static for us) PS4, Line 1690: for dev_object in dev_objects[:] This is also safe in both 2 and 3 as slice is still a copy -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches