Francesco Romani has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py File vdsm/virt/vm.py: PS4, Line 1690: for dev_object in dev_objects[:] > In this and setup case, the underlying libvirt domain is not even started - OK for setup, and right for teardown: I misread the code, apologies for that. Indeed we can't get here if dom.destroy() hasn't run, so the underlying libvirt domain should be in safe state, and no concurrent hot(un)plug is possible. Could you please add one-line docstring/comment here and in the setup code, like "Runs when the libvirt domain is destroyed"? -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
