Yaniv Kaul has posted comments on this change. Change subject: hooks:checkips: add checkips hook ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', > I checked a little behaviour of ping command: This is actually interesting. Suppose we have '-c 3' - and only two pings returned. What do we say about the connectivity? (I don't have a very good answer for 3. For 10 pings, I expect 9/10 - but I wonder in what error code ping would come out with!). Line 63: '-w', str(PING_TIMEOUT), Line 64: '-I', net, Line 65: address Line 66: ] -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
