Hunt Xu has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 6:
Line 7: extract a method for booting a test VM through kernel boot
Line 8:
Line 9: Hide the kernel boot and initramfs details into a method and provide a
Line 10: template configuration, then just call the metthod with custom VM
typo 'metthod' should be fixed here
Line 11: configurations
Line 12:
Line 13: Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c
....................................................
File tests/functional/xmlrpcTests.py
Line 179: 'vmName': 'vdsm_testSmallVM'}
Line 180:
Line 181: self._runVMKernelBootTemplate(customization)
Line 182:
Line 183: def _runVMKernelBootTemplate(self, vmDef):
what about def _runVMKernelBootTemplate(self, vmDef={}) to allow the use of the
template configuration below
Line 184: template = {'vmId': '11111111-abcd-2222-ffff-333333333333',
Line 185: 'vmName': 'vdsmKernelBootVM',
Line 186: 'display': 'vnc',
Line 187: 'kvmEnable': 'true',
--
To view, visit http://gerrit.ovirt.org/8414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
