Zhou Zheng Sheng has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot
......................................................................
Patch Set 6: (2 inline comments)
Thanks Hunt Xu , you suggestions are very wise.
....................................................
File tests/functional/xmlrpcTests.py
Line 57: if not os.path.isfile(kernelPath):
Line 58: raise SkipTest("Can not locate kernel image for release %s" %
Line 59: kernelVer)
Line 60: if not readableBy(kernelPath, QEMU_PROCESS_USER):
Line 61: raise SkipTest("qemu process can not read the file " %
kernelPath)
Done
Line 62:
Line 63: if os.path.isfile(initramfsPath):
Line 64: # There is an initramfs shipped with the distro, try use it
Line 65: if not readableBy(initramfsPath, QEMU_PROCESS_USER):
Line 166: template.update(vmDef)
Line 167: vmid = template['vmId']
Line 168:
Line 169: kernelArgsDistro = {'Fedora': 'rd.break=cmdline rd.shell
rd.skipfsck'}
Line 170: self.myAssertIn(distro, kernelArgsDistro)
Done
Line 171:
Line 172: def assertVMAndGuestUp():
Line 173: self.assertVmUp(vmid)
Line 174: self.assertGuestUp(vmid)
--
To view, visit http://gerrit.ovirt.org/8414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
