Francesco Romani has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class ......................................................................
Patch Set 5: Code-Review-1 (1 comment) the concept is fine, but this implementation could cause GC cycles, let's investigate this. -1 for visibility https://gerrit.ovirt.org/#/c/51781/5/lib/vdsm/virt/guestagent.py File lib/vdsm/virt/guestagent.py: PS5, Line 166: self.events = GuestAgentEvents(self) I'm just worried this causes a reference cycle, making the two objects uncollectable. -- To view, visit https://gerrit.ovirt.org/51781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dde856aa43bf130e28ce1ebc8cc7dac0341f45 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
