Francesco Romani has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 6: Code-Review+1 (3 comments) partial review looks good so far. Few questions/suggestions about the tests while I review the rest https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py File tests/vmTests.py: PS6, Line 1084: conf = {'vmName': 'testVm', 'vmId': '9ffe28b6-6134-4b1e-beef-1185f49c436f', : 'smp': '8', 'maxVCpus': '160', 'memSize': '1024', : 'memGuaranteedSize': '512', 'devices': []} nit: in _new_ code I'd really prefer to see conf = { 'vmName': 'testVm', ... 'devices': [], } PS6, Line 1100: with self.assertNotRaises(): : testvm._setup_devices() this works, but could be better: self.assertNotRaises(testvm._setup_devices) (here and below in a few other places) PS6, Line 1119: [('setup', (), {}), ('teardown', (), {}) it would be nicer if we could check that the device tore down was the same one that failed setup. Maybe add some identification to the device objects? :\ (I'm fine improving in a later patch) -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
